remove lambda remote service override configuration #151
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yiyuan-he
force-pushed
the
remove-remote-service-config
branch
2 times, most recently
from
bbc0b4f to
071d430
Compare
yiyuan-he
force-pushed
the
remove-remote-service-config
branch
from
071d430 to
4639a21
Compare
wangzlei
approved these changes
Feb 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
If user decides to override
RemoteService value, the Lambda Topology issue solution will not be able to support multiple downstream Lambdas.For example, consider lambdaA calls both lambdaB and lambdaC. If the user overrides
LAMBDA_APPLICATION_SIGNALS_REMOTE_SERVICE, it will effectively hardcode theRemoteServicevalue. As a result, we are left with an either/or situation where only one node will be connected to lambdaA in the topology depending on the hardcoded value. This issue is not present when the user does not override thisRemoteServicevalue because that attribute will dynamically take on whatever the lambda function name is.My proposal is we remove the
LAMBDA_APPLICATION_SIGNALS_REMOTE_SERVICEenv var. That is, we do not allow customers to override theRemoteServiceattribute value. This should not cause issues for customers to lose this configuration option. If the customer needs to change the downstream lambda service name, they can change the lambda function name itself rather than having to use an env var.Description of changes:
Removing option to override
RemoteServiceattribute value.Test plan:
Sanity e2e test by building custom lambda layer and ensuring the correct EMF Logs are still generated after change.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.